feat: Add the "s3fs.proxy.protocol" environment variable.

[stanakaj]

Pull Request Description

This pull request closes #719 .

Acceptance Test

• Building the code with gradle clean build still works.

Questions

• Does this pull request break backward compatibility?

  • Yes and my commit follows the Conventional Commits Specification
  • No

• Does this pull request require other pull requests to be merged first?

  • Yes, please see #...
  • No

• Does this require an update of the documentation?

  • Yes, please see [need to add the "s3fs.proxy.protocol" environment variable]
  • No

[stanakaj]

It seems that the s3fs.region setting is missing in the test. Please let me know if there is anything I can do to help.

    java.lang.IllegalArgumentException: region must not be blank or empty.
        at software.amazon.awssdk.utils.Validate.paramNotBlank(Validate.java:159)
        at software.amazon.awssdk.regions.Region.of(Region.java:136)

[steve-todorov]

Hey @stanakaj ,

Thank you very much for your contribution! :)

I believe that might be a false-positive exception related to how GH Actions runs workflows from forks (secrets are usually not passed to forks). I will check your PR manually in the upcoming days.

// cc @carlspring ICLA?

[steve-todorov]

@stanakaj I've checked your PR and overall it looks good. I assume you have tested it with a real proxy?

Could you please also add a test case covering the your proxy configuration case in S3ClientFactoryTest?

[stanakaj]

I added some test codes in S3ClientFactoryTest. The "differntProtocols" test is my proxy configuration scenario.

[steve-todorov]

Thanks for your contribution @stanakaj ! :)