Normalize dot directories #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennoruijters
force-pushed
the
normalize-dot-directories
branch
from
16d88e0
to
c05a8c6
Compare
carlspring
force-pushed
the
normalize-dot-directories
branch
from
c05a8c6
to
084310d
Compare
steve-todorov
force-pushed
the
normalize-dot-directories
branch
from
084310d
to
a02ab30
Compare
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
Co-authored-by: Enno Ruijters <[email protected]> Co-authored-by: Marcel Hekman <[email protected]>
steve-todorov
force-pushed
the
normalize-dot-directories
branch
from
a02ab30
to
6661aa3
Compare
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
steve-todorov
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
|
Hey @ennoruijters, Sorry it took only forever to get to it, but we were side-tracked by life and the pandemic. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #382.
Incidentally, this also makes the 'uri' and 'fileSystem' fields of S3Path final, to clarity that these are not to be changed.
Acceptance Test
mvn clean install -Punit-tests,it-minio,it-s3still works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?