Added support for nil date input. #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
1 similar comment
|
Bump |
|
@saboter hey hey, apologies for not getting back here... this is on my radar, just haven't had time lately but I'll be taking a look soon. Thanks. |
|
@carlosantoniodasilva Hello. Good news, thank you. I have enabled rails 6.1 in my fork in between which most probably broke the CI tests. |
|
@saboter right, thanks for that. I'm looking into those right now 👍 |
|
The fork is deployed in production for couple of days with newest Rails and so far no issues. |
|
Bump :). |
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice if the localized assign did not fail on nil date input.
E.g. object.localized({date_col: nil}) throws now:
no implicit conversion of nil into String
# /Users/work/.rvm/gems/ruby-2.5.8/gems/i18n_alchemy-0.3.1/lib/i18n_alchemy/date_parser.rb:9:in `_strptime'