Fix association_parser #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionController::Parameters does not implement method map.
There was a problem hiding this comment.
@rodrigoulisses the changes look good, but I'm afraid to_hash might raise an error for unpermitted parameters, I'll have to look into it and maybe adding some tests with AC::Parameters before merging this.
Did you hit any issue with a specific Rails version that you could give me more info? Thanks!
| @@ -19,7 +19,7 @@ def initialize(target_class, association_name) | |||
| # | |||
| def parse(attributes) | |||
| if association.macro == :has_many | |||
| attributes = attributes.is_a?(Hash) ? attributes.values : attributes | |||
| attributes = attributes.respond_to?(:to_hash) ? attributes.to_hash.values : attributes | |||
There was a problem hiding this comment.
Question: won't to_hash raise a deprecation warning in 5.0, and an exception in 5.1, when unpermitted? I guess we might need to add some tests with AC::Parameters to be sure.
carlosantoniodasilva
force-pushed
the
master
branch
from
00987c6
to
4e5f3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionController::Parameters does not implement method map.