Rename all mutating functions/macros by appending a !
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. add_arg_table -> add_arg_table! etc. Create deprecation warnings for the exported ones.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
- Coverage 96.31% 95.92% -0.4%
=========================================
Files 4 5 +1
Lines 1195 1201 +6
=========================================
+ Hits 1151 1152 +1
- Misses 44 49 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change is likely
@add_arg_table→@add_arg_table!.The others are
add_arg_table!,add_arg_group!,set_default_arg_group!, whileimport_settings!was done in a previous commit.(A major version bump seems like a good opportunity to finally fix this.)
Adds deprecation warnings for the exported ones so that existing codes shouldn't break (at least the tests don't...).
A slightly annoying side-effect is that in order to properly deprecate
@add_arg_tablewe must add an explicit dependency onLogging.There's also a minor change in
import_settings!signature.