Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for as_symbols=true when command is nothing #102

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

carlobaldassi
Copy link
Owner

Fix #100

@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #102 (fc537b9) into master (92764f2) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   95.92%   95.71%   -0.21%     
==========================================
  Files           5        5              
  Lines        1201     1283      +82     
==========================================
+ Hits         1152     1228      +76     
- Misses         49       55       +6     
Impacted Files Coverage Δ
src/parsing.jl 96.73% <100.00%> (-0.18%) ⬇️
src/settings.jl 96.48% <0.00%> (-0.21%) ⬇️
src/deprecated.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92764f2...fc537b9. Read the comment docs.

from Array{Int,1} to Vector{Int}
@carlobaldassi carlobaldassi merged commit 30705e8 into master Dec 5, 2020
@carlobaldassi carlobaldassi deleted the symcommandsfix branch December 5, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing failure with as_symbols=true and commands_are_required=false
2 participants