Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

fixing invalid UTF8 replacament for php 5.4, 5.5 #1057

Merged
merged 6 commits into from
Mar 5, 2014

Conversation

cm-jan
Copy link
Contributor

@cm-jan cm-jan commented Mar 5, 2014

Closes #1053

@cm-jan cm-jan self-assigned this Mar 5, 2014
@cm-jan
Copy link
Contributor Author

cm-jan commented Mar 5, 2014

@njam @fauvel please review

@njam
Copy link
Member

njam commented Mar 5, 2014

  • Remove note: "assuming always string"?
  • CM/FormField/Text.php: validate: Remove whitespace at beginning of method

@scrutinizer-notifier
Copy link

The inspection completed: 3 new/changed issues

@cm-jan
Copy link
Contributor Author

cm-jan commented Mar 5, 2014

@njam @fauvel please review

@njam
Copy link
Member

njam commented Mar 5, 2014

Looks good!

cm-jan added a commit that referenced this pull request Mar 5, 2014
fixing invalid UTF8 replacament for php 5.4, 5.5
@cm-jan cm-jan merged commit b6b5b14 into cargomedia:master Mar 5, 2014
njam added a commit to njam/CM that referenced this pull request Mar 5, 2014
This reverts commit b6b5b14, reversing
changes made to 768ba17.
@njam njam mentioned this pull request Mar 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling of invalid UTF-8 characters in form input
3 participants