This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Don't propagate clicks on managed form submission buttons #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
|
...but it might have unexpected side-effects. We'll have to check the UI thoroughly! @njam please merge if ok |
|
Maybe do some testing in fuboo first? |
Conflicts: library/CM/Form/Abstract.js
|
The inspection completed: No new issues |
|
I've done some exploratory testing, it seems to work. |
fauvel
added a commit
that referenced
this pull request
Mar 5, 2014
Don't propagate clicks on managed form submission buttons
|
Waiting for #1053 before doing a release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@njam @christopheschwyzer please review