Merge pull request #1644 from njam/form-viewResponse

Breaking: Change signature of Form::prepare()
cargomedia · Feb 18, 2015 · a8b1d34 · a8b1d34
2 parents f272e7d + 56d895e
commit a8b1d34
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/library/CM/Form/Abstract.js b/library/CM/Form/Abstract.js
@@ -86,6 +86,13 @@ var CM_Form_Abstract = CM_View_Abstract.extend({
     return this._fields[name];
   },
 
+  /**
+   * @return Boolean
+   */
+  hasField: function(name) {
+    return !!this._fields[name];
+  },
+
   /**
    * @return jQuery
    */

diff --git a/library/CM/Form/Abstract.php b/library/CM/Form/Abstract.php
@@ -30,7 +30,7 @@ public function __construct($params = null) {
         $this->_initialize();
     }
 
-    public function prepare(CM_Frontend_Environment $environment) {
+    public function prepare(CM_Frontend_Environment $environment, CM_Frontend_ViewResponse $viewResponse) {
     }
 
     /**

diff --git a/library/CM/Form/Example.php b/library/CM/Form/Example.php
@@ -22,7 +22,7 @@ protected function _initialize() {
         $this->registerAction(new CM_FormAction_Example_Go($this));
     }
 
-    public function prepare(CM_Frontend_Environment $environment) {
+    public function prepare(CM_Frontend_Environment $environment, CM_Frontend_ViewResponse $viewResponse) {
         if (CM_Http_Request_Abstract::hasInstance()) {
             $ip = CM_Http_Request_Abstract::getInstance()->getIp();
             if ($locationGuess = CM_Model_Location::findByIp($ip)) {

diff --git a/library/CM/Form/ExampleIcon.php b/library/CM/Form/ExampleIcon.php
@@ -12,7 +12,7 @@ protected function _initialize() {
         $this->registerField(new CM_FormField_Integer(['name' => 'shadowBlur', 'min' => 0, 'max' => 20]));
     }
 
-    public function prepare(CM_Frontend_Environment $environment) {
+    public function prepare(CM_Frontend_Environment $environment, CM_Frontend_ViewResponse $viewResponse) {
         $this->getField('sizeSlider')->setValue(18);
         $this->getField('shadowColor')->setValue('#333');
         $this->getField('colorBackground')->setValue('#fafafa');

diff --git a/library/CM/SmartyPlugins/block.form.php b/library/CM/SmartyPlugins/block.form.php
@@ -6,9 +6,9 @@ function smarty_block_form($params, $content, Smarty_Internal_Template $template
     $frontend = $render->getGlobalResponse();
     if ($open) {
         $form = CM_Form_Abstract::factory($params['name'], $params);
-        $form->prepare($render->getEnvironment());
-
         $viewResponse = new CM_Frontend_ViewResponse($form);
+        $form->prepare($render->getEnvironment(), $viewResponse);
+
         $frontend->treeExpand($viewResponse);
         return '';
     } else {
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ public function __construct($params = null) { @@
             $this->_initialize();
         }
-        public function prepare(CM_Frontend_Environment $environment) {
+        public function prepare(CM_Frontend_Environment $environment, CM_Frontend_ViewResponse $viewResponse) {
         }
         /**
@@ Expand Down @@