Merge pull request #2645 from christopheschwyzer/autosave-text

BREAKING CM-CR-83 FB-643 Introduce "disableTriggerChangeOnInput" for CM_FormField_Text
cargomedia · Jun 13, 2017 · 0038905 · 0038905
2 parents ba035d4 + b329881
commit 0038905
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/library/CM/Form/Example.js b/library/CM/Form/Example.js
@@ -10,10 +10,6 @@ var CM_Form_Example = CM_Form_Abstract.extend({
     this.getFields().forEach(function(field) {
       field.on('ready', function() {
         field.on('change', form.logData.bind(form));
-
-        if (field instanceof CM_FormField_Text) {
-          field.enableTriggerChangeOnInput();
-        }
       });
     });
 

diff --git a/library/CM/FormField/Password.js b/library/CM/FormField/Password.js
@@ -17,8 +17,6 @@ var CM_FormField_Password = CM_FormField_Text.extend({
   },
 
   ready: function() {
-    this.enableTriggerChangeOnInput();
-
     var self = this;
     var visibilityDesired;
     this.getForm()

diff --git a/library/CM/FormField/Text.js b/library/CM/FormField/Text.js
@@ -51,9 +51,9 @@ var CM_FormField_Text = CM_FormField_Abstract.extend({
     }
   },
 
-  /**
-   * @deprecated No need to call this function anymore. Text field always triggers "change".
-   */
-  enableTriggerChangeOnInput: function() {
+  disableTriggerChangeOnInput: function() {
+    this.delegateEvents(
+      _(this.events).omit('input input')
+    );
   }
 });
diff --git a/library/CM/FormField/Textarea.js b/library/CM/FormField/Textarea.js
@@ -8,6 +8,7 @@ var CM_FormField_Textarea = CM_FormField_Text.extend({
   events: {
     'blur [contenteditable]': function() {
       this.trigger('blur');
+      this.triggerChange();
     },
     'focus [contenteditable]': function() {
       this.trigger('focus');
@@ -87,6 +88,12 @@ var CM_FormField_Textarea = CM_FormField_Text.extend({
     this.setValue('');
   },
 
+  disableTriggerChangeOnInput: function() {
+    this.delegateEvents(
+      _(this.events).omit('input [contenteditable]')
+    );
+  },
+
   /**
    * @param {String} text
    * @returns {string}