Skip to content

Commit

Permalink
Explicit runtime (#32)
Browse files Browse the repository at this point in the history
* typesafe supported runtimes

* update docs

* Document the default runtime and how to change it.

Signed-off-by: David Calavera <[email protected]>

* Disable fleaky tests.

Signed-off-by: David Calavera <[email protected]>

* Run tests serially.

Signed-off-by: David Calavera <[email protected]>

* chore: self mutation

Signed-off-by: github-actions <[email protected]>

* Remove self-mutating tasks.

Signed-off-by: David Calavera <[email protected]>

---------

Signed-off-by: David Calavera <[email protected]>
Signed-off-by: github-actions <[email protected]>
Co-authored-by: Christian Hoffmann <[email protected]>
Co-authored-by: github-actions <[email protected]>
  • Loading branch information
3 people authored Feb 14, 2024
1 parent f44cc1a commit 255a906
Show file tree
Hide file tree
Showing 8 changed files with 899 additions and 943 deletions.
49 changes: 2 additions & 47 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,24 +49,7 @@ jobs:
- name: Install dependencies
run: npx projen install:ci
- name: build
run: npx projen build
- name: Find mutations
id: self_mutation
run: |-
git add .
git diff --staged --patch --exit-code > .repo.patch || echo "self_mutation_happened=true" >> $GITHUB_OUTPUT
- name: Upload patch
if: steps.self_mutation.outputs.self_mutation_happened
uses: actions/upload-artifact@v3
with:
name: .repo.patch
path: .repo.patch
- name: Fail build on mutation
if: steps.self_mutation.outputs.self_mutation_happened
run: |-
echo "::error::Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch."
cat .repo.patch
exit 1
run: npx projen build --verbose
- name: Backup artifact permissions
run: cd dist && getfacl -R . > permissions-backup.acl
continue-on-error: true
Expand All @@ -75,35 +58,7 @@ jobs:
with:
name: build-artifact
path: dist
self-mutation:
needs: build
runs-on: ubuntu-latest
permissions:
contents: write
if: always() && needs.build.outputs.self_mutation_happened && !(github.event.pull_request.head.repo.full_name != github.repository)
steps:
- name: Checkout
uses: actions/checkout@v3
with:
token: ${{ secrets.PROJEN_GITHUB_TOKEN }}
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
- name: Download patch
uses: actions/download-artifact@v3
with:
name: .repo.patch
path: ${{ runner.temp }}
- name: Apply patch
run: '[ -s ${{ runner.temp }}/.repo.patch ] && git apply ${{ runner.temp }}/.repo.patch || echo "Empty patch. Skipping."'
- name: Set git identity
run: |-
git config user.name "github-actions"
git config user.email "[email protected]"
- name: Push changes
run: |2-
git add .
git commit -s -m "chore: self mutation"
git push origin HEAD:${{ github.event.pull_request.head.ref }}

package-js:
needs: build
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 14 additions & 4 deletions API.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion LICENSE

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,17 @@ lambda-project

### Runtime

The `RustFunction` uses the `PROVIDED_AL2` runtime.
The `RustFunction` uses the `PROVIDED_AL2023` runtime. If you want to change it, you can use the property `runtime`:

```
```ts
import { RustFunction } from 'cargo-lambda-cdk';
new RustFunction(stack, 'Rust function', {
manifestPath: 'path/to/package/directory/with/Cargo.toml',
runtime: 'provided.al2',
});
```

## Rust Extension

Expand Down
2 changes: 1 addition & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/function.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@ export interface RustFunctionProps extends FunctionOptions {

/**
* The Lambda runtime to deploy this function with. `provided.al2023` is the default.
*
* The only valid values are `provided.al2023` and `provided.al2`.
*/
readonly runtime?: string;
readonly runtime?: 'provided.al2023' | 'provided.al2';

/**
* Path to a directory containing your Cargo.toml file, or to your Cargo.toml directly.
Expand Down
Loading

0 comments on commit 255a906

Please sign in to comment.