Made a bat for running tests #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderHansson4225
requested review from
anahitachavan,
adammansson,
MrMikkelsen,
Sepehr-trp,
emil-ronkainen,
Stronkness,
IsaRandsalu,
sandrachristoffersen,
HienMyTruong and
S1monG
S1monG
reviewed
May 19, 2023
runTests.bat
Outdated
| ) | ||
| docker run -d --name nexpo_database -p 5432:5432 -e POSTGRES_USER=nexpo -e POSTGRES_PASSWORD=nexpo postgres:14 | ||
| ) ELSE IF "%1"=="-run" ( | ||
| IF "%2"=="" ( |
There was a problem hiding this comment.
It doesn't check if the database is running when you don't leave an argument after the -run flag. Is this intentional?
There was a problem hiding this comment.
This was not intentional, good observation! Thank you, I will fix that
|
@S1monG and @emil-ronkainen |
|
Would be great if anyone could check if it works as intended now, after the fix. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important:
Please review, esspecially if you have a windows computer (i dont know who of you have windows, so I just added all of you for review)
Due to me not having a bat compiler (a windows computer), I have not been able to test the bat file. So before you write a comment, please check it thoroughly. Especially:
If you receive issues, please tell me (if they are not easy for you to fix) - if you can fix it and you have a bat compiler, please do. Ask if anything is unclear of how to use the script. See -help flag for help <3
If it does not work, and you can not fix it, we can fix it on a thursday on someones windows computer