Check room membership before processing events in room resource #2179
+114
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
check-room-members-before-processing-events
branch
from
d78af75 to
ebb034f
Compare
lukemelia
force-pushed
the
check-room-members-before-processing-events
branch
from
ebb034f to
e8d8ef8
Compare
habdelra
reviewed
Feb 21, 2025
Comment on lines
+119
to
+122
| if (!memberIds) { | ||
| return; | ||
| } | ||
| if (!memberIds.includes(this.matrixService.aiBotUserId)) { |
There was a problem hiding this comment.
nit: you could collapse this into a single if using an "or"
habdelra
reviewed
Feb 21, 2025
| @@ -44,6 +44,14 @@ export default class Room { | |||
| ?.name; | |||
| } | |||
|
|
|||
| get memberIds(): string[] { | |||
There was a problem hiding this comment.
this seems like something that should be using @cached no? every call to this property will run this logic
habdelra
reviewed
Feb 21, 2025
| assert.dom('[data-test-profile-display-name]').hasText(''); // No display name set yet | ||
| assert | ||
| .dom('[data-test-profile-icon]') | ||
| .hasStyle({ backgroundColor: 'rgb(34, 221, 152)' }); | ||
| .hasStyle({ backgroundColor: 'rgb(88, 226, 29)' }); |
There was a problem hiding this comment.
The "server" of the testuser changed from staging to localhost, which results in a different color for the avatar background
habdelra
reviewed
Feb 21, 2025
| @@ -1030,7 +1030,7 @@ module('Acceptance | operator mode tests', function (hooks) { | |||
| assert.dom('[data-test-profile-icon]').hasText('T'); | |||
| assert | |||
| .dom('[data-test-profile-icon]') | |||
| .hasStyle({ backgroundColor: 'rgb(34, 221, 152)' }); | |||
| .hasStyle({ backgroundColor: 'rgb(88, 226, 29)' }); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.