Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove content-scroll-container from content-grid & add scroll to content #2164

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

lucaslyl
Copy link
Contributor

linear:https://linear.app/cardstack/issue/ECO-165/prevent-the-extra-scroll-in-crm-app-container

Result:

Screen.Recording.2025-02-19.at.16.49.29.mov

@lucaslyl lucaslyl self-assigned this Feb 19, 2025
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   24m 28s ⏱️ + 1m 47s
769 tests ±0  767 ✔️ ±0  2 💤 ±0  0 ±0 
774 runs  ±0  772 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit e4014e4. ± Comparison against base commit 22ebcca.

Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as how I expected

Copy link
Contributor

@richardhjtan richardhjtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lucaslyl lucaslyl merged commit 65ebc95 into main Feb 20, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants