Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change task planner sort order when LHS filter changes #2160

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Change task planner sort order when LHS filter changes #2160

merged 4 commits into from
Feb 21, 2025

Conversation

richardhjtan
Copy link
Contributor

Refer to https://linear.app/cardstack/issue/CS-7607/task-planner-change-sort-order-when-lhs-filter-changes

What is changing

  • Change task planner sort order when LHS filter changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Host Test Results

    1 files  ±0      1 suites  ±0   23m 20s ⏱️ -2s
773 tests ±0  771 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
778 runs  ±0  776 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 005d734. ± Comparison against base commit ff478ab.

♻️ This comment has been updated with latest results.

burieberry
burieberry reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't review this because came across the following pre-existing bugs: ECO-163, ECO-169, ECO-170

tintinthong
tintinthong approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@richardhjtan richardhjtan merged commit 21df636 into main Feb 21, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burieberry burieberry burieberry left review comments

@tintinthong tintinthong tintinthong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardhjtan @tintinthong @burieberry