code ref should serialize to relative #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set null only when card.id does not exist
tintinthong
force-pushed
the
cs-7930-code-ref-should-serialize-relative-url
branch
from
3846683 to
8ad51f6
Compare
…n nested serialization
habdelra
reviewed
Feb 19, 2025
| @@ -2294,8 +2299,9 @@ async function getDeserializedValue<CardT extends BaseDefConstructor>({ | |||
| export interface SerializeOpts { | |||
| includeComputeds?: boolean; | |||
| includeUnrenderedFields?: boolean; | |||
| maybeRelativeURL?: ((possibleURL: string) => string) | null; // setting this to null will force all URL's to be absolute | |||
| useAbsoluteURL?: boolean; | |||
habdelra
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs that get created now will serialize the code ref fields into relative urls. Similarly, if you had an absolute url, an auto-save will serialise it relative. These happen on the server. This changes will apply to any card with code ref field.
Before
After