Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cs 7896 try to change loading text indicator into loadingindicatoricon #2150

Conversation

lucaslyl
Copy link
Contributor

linear: https://linear.app/cardstack/issue/CS-7896/try-to-change-loading-text-indicator-into-loadingindicatoricon

Implement Skeleton Loader Component and Integrate into Card Query Loading States

  • Boxel UI Component - Skeleton Placeholder: Added a reusable Skeleton component to display placeholder content during loading states.
  • Skeleton Loader Animations: Implemented three animation types for the Skeleton Loader: wave, pulse, and none.
  • CSS Variable Controls: Added support for customizable properties via CSS variables: width, height, border-radius, background color, and highlight color.
  • Integration: Applied the Skeleton Loader to all card query loading states to improve user experience during data fetching.

Demo in Boxel Ui:

Screen.Recording.2025-02-17.at.11.40.45.mov

Result in CRM Account:
Screenshot 2025-02-17 at 11 01 33

@lucaslyl lucaslyl self-assigned this Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 42s ⏱️ +18s
764 tests ±0  761 ✔️ ±0  3 💤 ±0  0 ±0 
769 runs  ±0  766 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit a842f83. ± Comparison against base commit 58676fa.

♻️ This comment has been updated with latest results.

@lucaslyl lucaslyl requested a review from a team February 17, 2025 08:09
@lucaslyl lucaslyl marked this pull request as ready for review February 17, 2025 08:09
@lucaslyl lucaslyl merged commit 8dd91df into main Feb 19, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants