Add task and query tasks in deal page #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhjtan
force-pushed
the
CS-7793-query-active-task-in-deal
branch
from
cd4bf3a to
f82e938
Compare
tintinthong
approved these changes
Jan 21, 2025
tintinthong
reviewed
Jan 21, 2025
| {{#if this.activeTasks.isLoading}} | ||
| Loading... | ||
| {{else if this.activeTasks.instances}} | ||
| {{this.activeTasks.instances.length}} |
There was a problem hiding this comment.
We shud update all Loading to use the LoadingIndicatorIcon
There was a problem hiding this comment.
@tintinthong Sounds good, I will separate this into a single UI ticket
There was a problem hiding this comment.
@tintinthong I think of it when there is a lot "loading" state from each section, a lot of loading indicators will show up, which may look cluttered. I will leave the ticket for trying to replace it, and see if the UX is good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to https://linear.app/cardstack/issue/CS-7793/query-active-task-in-deal
What is changing