Invalidation performance improvement #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
changed the title
backspace
approved these changes
Jan 17, 2025
|
|
||
| let ignoreFile = new URL('.gitignore', url).href; | ||
| // it costs about 10 sec to try to get the ignore file when it doesn't | ||
| // exist, so don't get it if it's not there. |
lukemelia
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves invalidation performance. I've used
EXPLAIN ANALYZEon our query that discovers files to invalidate. In doing so I've found that ourSORTincurs unnecessary overhead (there is no need to sort these results, they are not displayed), as well as ourCOALESCEwhich actually subverts ourGINindex on thedepscolumn. Also, I added a new compound index on thetypeandrealm_urlcolumns as indicated in theEXPLAIN. These items together cut the invalidation query to about <10ms in staging (which amounts to a lot in the aggregate).The much bigger item, tho, is to skip the retrieval of the ignore rules when there are no ignore rules (which is almost all the time). This saves about 8-10 sec on the from-scratch indexing when booting.
TODO: