Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use CardsGrid when using embedded-view #2053

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

burieberry
Copy link
Contributor

This is to prevent embedded-card view from getting cropped.

Copy link

github-actions bot commented Jan 16, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 35s ⏱️ +21s
729 tests ±0  727 ✔️ ±0  2 💤 ±0  0 ±0 
734 runs  ±0  732 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 716e7ab. ± Comparison against base commit 5b3d1aa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, as well as avoiding the problematic layout issue. 👍

@burieberry burieberry merged commit cc54e6e into main Jan 17, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants