-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add viewable Matrix test Playwright reports #1169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now?
It keeps saying it’s not found…? Downtime???
I don’t really want this here… hopefully can be fixed later
This will surely fail!
It seems like I need a rewriting function to append this automatically…? No thanks
S3 sync is synchronous, presumably, no more delay.
ugh… so brittle, YAML
This is more precise.
habdelra
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Matrix tests fail in CI we don’t get much visibility into why. This publishes the Playwright report with traces to S3 so it can be easily inspected. Here is an example report with a trace on a timed-out test.
The publishing is adapted from @adrian-maciuc’s article Publish your playwright reports to github pages, though it now publishes to S3.
I replaced the tag-based grouping of tests for paralellisation in CI with the built-in sharding which removes the need for snapshots to be duplicated for each group. I experimented with different shard counts:
One repetition isn’t a thorough experiment but I settled on six shards as it wasn’t that much slower than ten and the latter seemed excessive.
After all the shard jobs complete a job runs that merges the reports and publishes them. Thanks to @marshmn on the Playwright Discord for pointing out that an old Playwright version was causing problems with the merge.
The link to the Playwright report is appended in a status: