Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glimmer-scoped-css to 0.4.1 in all packages #1158

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Update glimmer-scoped-css to 0.4.1 in all packages #1158

merged 3 commits into from
Apr 11, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Apr 11, 2024 •
edited
Loading

This updates the boxel-ui Rollup configuration to use the new interface of decodeScopedCSSRequest, otherwise you see errors like this:

[!] (plugin scoped-css) RollupError: Could not set source for asset "components/accordion/8042e6ceab.css", asset source needs to be a string, Uint8Array or Buffer.
    at error (/home/runner/work/boxel/boxel/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/shared/rollup.js:353:30)
    at getValidSource (/home/runner/work/boxel/boxel/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/shared/rollup.js:1133:16)
    at FileEmitter.emitAsset (/home/runner/work/boxel/boxel/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/shared/rollup.js:1293:15)
    at FileEmitter.emitFile (/home/runner/work/boxel/boxel/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/shared/rollup.js:1173:25)
    at Object.generateBundle (file:///home/runner/work/boxel/boxel/packages/boxel-ui/addon/rollup.config.mjs:108:16)
    at /home/runner/work/boxel/boxel/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/shared/rollup.js:1913:40

Is it worth using @rollup/plugin-typescript to allow us to use a Typescript config file? That would have made the fix more obvious.

A similar change is needed in …/runtime-common/loader.ts.

@backspace backspace added bug Something isn't working chore labels Apr 11, 2024
@backspace backspace self-assigned this Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Test Results

584 tests  ±0   580 ✔️ ±0   8m 11s ⏱️ -31s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 2fa08f0. ± Comparison against base commit 9a12651.

♻️ This comment has been updated with latest results.

@backspace
Fix use of decoder return type
5b5a458 
This was masked by the file being mjs!
@backspace backspace changed the title Update glimmer-scoped-css in all packages Update glimmer-scoped-css to 0.4.1 in all packages Apr 11, 2024
@backspace backspace marked this pull request as ready for review April 11, 2024 02:55
@backspace backspace requested a review from a team April 11, 2024 02:55
@jurgenwerk jurgenwerk requested a review from a team April 11, 2024 06:39
lukemelia
lukemelia approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes me think that we should label the breaking change in glimmer-scoped-css release notes.

@backspace backspace merged commit 0fc8f68 into main Apr 11, 2024
25 checks passed
@delete-merged-branch delete-merged-branch bot deleted the glimmer-scoped-css-0.4.1-cs-6701 branch April 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemelia lukemelia lukemelia approved these changes

@jurgenwerk jurgenwerk jurgenwerk approved these changes

Assignees

@backspace backspace

Labels
bug Something isn't working chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@backspace @lukemelia @jurgenwerk