CI should lint runtime common #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgenwerk
force-pushed
the
cs-6649-ci-should-lint-runtime-common
branch
from
4e00450 to
0473fef
Compare
jurgenwerk
requested review from
lukemelia,
backspace,
habdelra,
tintinthong,
FadhlanR and
burieberry
tintinthong
approved these changes
Apr 10, 2024
jurgenwerk
commented
Apr 10, 2024
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable no-useless-escape */ | |||
There was a problem hiding this comment.
Disabling this because test fixtures have whitespace that prettier wants to fix. We don't want that because these are compared against generated code.
lukemelia
approved these changes
Apr 10, 2024
backspace
approved these changes
Apr 10, 2024
delete-merged-branch
bot
deleted the
cs-6649-ci-should-lint-runtime-common
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lint check for runtime-common and fixes files to conform to the rules.