Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement on refactor group resizable panel test #1149

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Apr 8, 2024

This is 1st step in possibly refactoring resizable panel. Basically, a lot of discussion/confusion fadhlan and I have is which argument is preferred defaultLengthFraction or lengthPx or minLengthPx-- I anticipate that we shud add these arguments that will be tested. And their easily mutable doing the same test setup.

If test pass it should be good to go in. These are only changes to the test

This doesn't change any application code only test code

Copy link

github-actions bot commented Apr 8, 2024

Test Results

576 tests  ±0   572 ✔️ ±0   8m 24s ⏱️ -25s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 5739ccb. ± Comparison against base commit 789e59d.

@tintinthong tintinthong requested a review from a team April 8, 2024 12:34
@tintinthong tintinthong changed the title Small improvement on refactor resizable panel test Small improvement on refactor group resizable panel test Apr 8, 2024
Copy link
Contributor

@jurgenwerk jurgenwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just wondering why a refactor is needed? Are there bugs in the panel implementation?

@jurgenwerk jurgenwerk requested a review from a team April 8, 2024 14:02
@tintinthong
Copy link
Contributor Author

tintinthong commented Apr 8, 2024

Looks good just wondering why a refactor is needed? Are there bugs in the panel implementation?

Fair question. Well the bugs which we currently see is

The 2nd ticket is merged and fixed. But its a workaround.

Ok as part of the refactor

  1. want to solve the bugs above
  2. separate the actions of register/unregister and onContainerResize. We seem to rely onContainerResize to often make sure the panel ratios are correct. My question was always, why arent the ratios correct after registering a panel
  3. hide ratio computation in an abstraction
  4. have greater clarity with usage of arguments

I think if we do 2 . we should fix the bugs. Perhaps that is a good place to stop (tho I suspect itll be a pain to do it without 3)

@tintinthong tintinthong merged commit c15988d into main Apr 9, 2024
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-resizable-panel-add-test branch April 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants