Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "every" filter support for our queries #1142

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Apr 4, 2024

his PR is branched from #1141. Please review and merge that PR first. Currently, commit 6accd31 has all the actual changes for this PR.

This PR introduces "every" filter support for our queries

Copy link

github-actions bot commented Apr 4, 2024

Test Results

576 tests  +6   572 ✔️ +6   8m 18s ⏱️ -18s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 6accd31. ± Comparison against base commit fed915a.

This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.
Chrome 123.0 ‑ Integration | search-index > query: can use a range filter with custom queryableValue
Chrome 123.0 ‑ Integration | search-index > query: can use a range filter with custom formatQuery
Chrome 123.0 ‑ Integration | search-index > query: can use an eq filter with a date field
Chrome 123.0 ‑ Unit | query: can filter eq from a code ref query value
Chrome 123.0 ‑ Unit | query: can filter eq from a date query value
Chrome 123.0 ‑ Unit | query: can handle a filter with double negatives
Chrome 123.0 ‑ Unit | query: can search with a 'not' filter
Chrome 123.0 ‑ Unit | query: can use 'every' to combine multiple filters

♻️ This comment has been updated with latest results.

@habdelra habdelra merged commit 4820358 into main Apr 5, 2024
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cs-6659-support-for-every-filter-queries branch April 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants