The same version of the card must be sent only one time #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FadhlanR
requested review from
lukemelia,
IanCal,
habdelra,
jurgenwerk and
burieberry
habdelra
reviewed
Apr 1, 2024
habdelra
reviewed
Apr 1, 2024
habdelra
reviewed
Apr 1, 2024
habdelra
reviewed
Apr 3, 2024
| @@ -69,4 +70,5 @@ export function shimExternals(virtualNetwork: VirtualNetwork) { | |||
| virtualNetwork.shimModule('ember-source/types/preview', { | |||
| default: class {}, | |||
| }); | |||
| virtualNetwork.shimModule('super-fast-md5', superFastMD5); | |||
lukemelia
approved these changes
Apr 4, 2024
Co-authored-by: Luke Melia <[email protected]>
Co-authored-by: Luke Melia <[email protected]>
delete-merged-branch
bot
deleted the
cs-6578-send-the-same-version-of-the-card-one-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CS-6578
The PR aims to prevent redundant card fragment events in a conversation by ensuring that the same version of a card is sent only once. This is achieved by introducing a new map in the room module, which maps the
cardDocto theeventId. This way, thesendCardFragmentsfunction is called only when there is noeventIdfor the attachedcardDoc.