Skip to content

Commit

Permalink
ci: Add job to fail on changes to generated icons (#1136)
Browse files Browse the repository at this point in the history
This adds a job that fails if the output of pnpm rebuild:icons results
in any diffs, which indicates that a generated icon component was
changed without the underlying raw icon being the source. This prevents
the need for #1135.
  • Loading branch information
backspace authored Apr 10, 2024
1 parent fe40346 commit 9a12651
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,21 @@ jobs:
run: pnpm test
working-directory: packages/boxel-ui/test-app

boxel-ui-raw-icon-changes-only:
name: Boxel UI ensure raw icon changes only
runs-on: ubuntu-latest
concurrency:
group: boxel-ui-raw-icon-changes-only-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/init
- name: Rebuild boxel-ui icons
run: pnpm rebuild:icons
working-directory: packages/boxel-ui/addon
- name: Fail if generated icons have been changed without underlying raw icon changing
run: git diff --exit-code

host-test:
name: Host Tests
runs-on: ubuntu-latest
Expand Down

0 comments on commit 9a12651

Please sign in to comment.