Cleanup

cardstack · Jan 20, 2025 · 62ba7b9 · 62ba7b9
1 parent be60654
commit 62ba7b9
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 12 deletions.
diff --git a/packages/experiments-realm/SprintTask/cocojambo.txt b/packages/experiments-realm/SprintTask/cocojambo.txt
diff --git a/packages/host/app/components/operator-mode/interact-submode.gts b/packages/host/app/components/operator-mode/interact-submode.gts
@@ -304,18 +304,25 @@ export default class InteractSubmode extends Component<Signature> {
               title: loadedCard.title,
             };
           } catch (error: any) {
-            // Case when card is in error state
-            let cardTitle = JSON.parse(error.responseText)?.errors?.[0]?.meta
-              ?.cardTitle;
+            // If we get a 500 Internal Server Error, it is probable that the card is in error state.
+            // In this case a cardTitle should be present - we use this to display the card title in the delete modal.
+            if (error.status === 500) {
+              let cardTitle = JSON.parse(error.responseText)?.errors?.[0]?.meta
+                ?.cardTitle;
+
+              if (!cardTitle) {
+                throw new Error(
+                  `Could not get card title for ${card} - the server returned a 500 but perhaps for other reason than the card being in error state`,
+                );
+              }
 
-            if (!cardTitle) {
-              throw new Error(`Could not get card title for ${card}`);
+              cardToDelete = {
+                id: cardUrl.href,
+                title: cardTitle,
+              };
+            } else {
+              throw error;
             }
-
-            cardToDelete = {
-              id: cardUrl.href,
-              title: cardTitle,
-            };
           }
         }
 

diff --git a/packages/host/app/components/operator-mode/stack-item.gts b/packages/host/app/components/operator-mode/stack-item.gts
@@ -282,7 +282,7 @@ export default class OperatorModeStackItem extends Component<Signature> {
     return cardTypeDisplayName(this.card);
   }
 
-  private get moreOptionsMenuItemsForCardInError() {
+  private get moreOptionsMenuItemsForErrorCard() {
     if (this.isBuried) {
       return undefined;
     }
@@ -630,7 +630,7 @@ export default class OperatorModeStackItem extends Component<Signature> {
             @cardTypeDisplayName={{this.cardErrorTitle}}
             @cardTypeIcon={{ExclamationCircle}}
             @isTopCard={{this.isTopCard}}
-            @moreOptionsMenuItems={{this.moreOptionsMenuItemsForCardInError}}
+            @moreOptionsMenuItems={{this.moreOptionsMenuItemsForErrorCard}}
             @onClose={{unless this.isBuried (perform this.closeItem)}}
             class='stack-item-header stack-item-header-error'
             style={{cssVar