rhel/fedora fixes #1851
Open
rhel/fedora fixes #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBenson
requested changes
Feb 21, 2025
| @@ -229,7 +229,7 @@ os_dependencies() { | |||
| pkg_list="${pkg_list} libusb ncurses-compat-libs pkgconfig" | |||
| elif [[ "${VERSION_ID}" =~ "8" ]] || [[ "${VERSION_ID}" =~ "9" ]]; then | |||
| #RHEL/CentOS/RockyLinux 8/9 | |||
| pkg_opts="${pkg_opts} --allowerasing" | |||
| if ${pkgmgrcmd} -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi | |||
There was a problem hiding this comment.
This works for dnf v4 as the root usage menu displays this as a General DNF option. However, in dnf v5 --allowerasing no longer visible here, it is only visible in the usage for Options of the applicable subcommands.
This can be used to achieve your goal as both v4 and v5 list this in the usage menu for the install and update subcommands:
Suggested change
| if ${pkgmgrcmd} -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi | |
| if ${pkgmgrcmd} install -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi |
| @@ -238,7 +238,7 @@ os_dependencies() { | |||
| fi | |||
| elif [[ "${DISTRO}" =~ Fedora ]]; then | |||
| #Fedora | |||
| pkg_opts="${pkg_opts} --allowerasing" | |||
| if ${pkgmgrcmd} -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi | |||
There was a problem hiding this comment.
Same as above comment for dnf v4 vs. v5:
Suggested change
| if ${pkgmgrcmd} -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi | |
| if ${pkgmgrcmd} install -h | grep -q "\--allowerasing"; then pkg_opts="${pkg_opts} --allowerasing"; fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
guild-deploy fixes for recent RHEL / Fedora versions