fix(web-components): specify files/dirs to include in package #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
requested review from
devadula-nandan and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6688 +/- ##
==========================================
+ Coverage 80.68% 80.71% +0.03%
==========================================
Files 397 397
Lines 12923 12940 +17
Branches 4286 4291 +5
==========================================
+ Hits 10427 10445 +18
+ Misses 2496 2495 -1
|
davidmenendez
approved these changes
Jan 16, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jan 16, 2025
be14cc3
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6674
Found another problem in the web component build setup, the
iconsdirectory was not being included in the build output which again resulted in the same bug originally described in #6674. Including thefilesproperty in the package.json should fix this since theiconsdirectory will be included inside ofesandlib.Update
Changing the icon imports to
@carbon/web-components/es/icons/**/*fixes the issue and allows us to remove the build plugins for transforming the icons since we really should just import them directly from the@carbon/web-componentspackage. Thanks @sangeethababu9223 for the suggestion! 💡What did you change?