Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): onRowClick results in toggleRow.toggleRowSelected is not a function error in console #6633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Dec 31, 2024

Closes #6547

Added a null check for toggleRowSelected callback since for some rows objects, toggleRowSelected is not present.

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner December 31, 2024 08:59
@amal-k-joy amal-k-joy requested review from elycheea and AlexanderMelox and removed request for a team December 31, 2024 08:59
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 503ebb0
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6773b27278251f00084587b0
😎 Deploy Preview https://deploy-preview-6633--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 503ebb0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6773b272f5b3ac0008694701
😎 Deploy Preview https://deploy-preview-6633--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy changed the title fix: add null check for callback fix(Datagrid): onRowClick results in toggleRow.toggleRowSelected is not a function error in console Dec 31, 2024
@amal-k-joy amal-k-joy marked this pull request as draft December 31, 2024 09:00
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (cc8f1aa) to head (503ebb0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6633   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files         396      396           
  Lines       12893    12894    +1     
  Branches     4274     4276    +2     
=======================================
+ Hits        10415    10417    +2     
+ Misses       2478     2477    -1     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@amal-k-joy amal-k-joy marked this pull request as ready for review January 1, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant