-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gh action to apply PR review labels #5656
feat: gh action to apply PR review labels #5656
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
return; | ||
} | ||
|
||
if (approved.length >= 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think we really need this step, unless there’s an operational reason we want to pull the label back off. But doesn’t really hurt either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow this is terrific!
7bbeaf5
Closes #5535
This action adds review labels to PRs (specifically the
status: one more review
label) to help us streamline our review process a bit.Here is a rough summary of the steps taken:
received-pr-review.yml
workflow is triggered when a review is submitted, either an approval or requested changes.github.event
data as a workflow artifact that is later used fromprocess-pr-review-data.yml
.received-pr-review.yml
completes, theprocess-pr-review-data.yml
workflow will be dispatched and will make a request for the previously created workflow artifact.What did you change?
How did you test and verify your work?
In test repo:
Successful
process-pr-review-data
workflowExample PR with label applied