Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conditionBuilder): accessibility and generic issue fixes #5647

Merged
merged 3 commits into from
Jul 11, 2024
Merged

feat(conditionBuilder): accessibility and generic issue fixes #5647

merged 3 commits into from
Jul 11, 2024

Conversation

amal-k-joy
Copy link
Contributor

Contributes #4916 , #5640

  • Implementation to show content as 'incomplete' when user close the popover without selecting any values
  • Edge case issue when user delete all plain condition keeping only subgroups in a group
  • Mange tab index and focus
  • Accessibility fixes

How did you test and verify your work?

Local storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner July 8, 2024 10:27
@amal-k-joy amal-k-joy requested review from emyarod and ariellalgilmore and removed request for a team July 8, 2024 10:27
@amal-k-joy amal-k-joy enabled auto-merge July 8, 2024 10:27
@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 5effd67
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/668e74d8d491630008f06f1c
😎 Deploy Preview https://deploy-preview-5647--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidmenendez
davidmenendez requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments for ya

...es/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItem.js Outdated Show resolved Hide resolved
.../ibm-products/src/components/ConditionBuilder/ConditionGroupBuilder/ConditionGroupBuilder.js Outdated Show resolved Hide resolved
.../ibm-products/src/components/ConditionBuilder/ConditionGroupBuilder/ConditionGroupBuilder.js Outdated Show resolved Hide resolved
.../ibm-products/src/components/ConditionBuilder/ConditionGroupBuilder/ConditionGroupBuilder.js Outdated Show resolved Hide resolved
.../ibm-products/src/components/ConditionBuilder/ConditionGroupBuilder/ConditionGroupBuilder.js Outdated Show resolved Hide resolved
@amal-k-joy amal-k-joy requested a review from davidmenendez July 10, 2024 07:49
davidmenendez
davidmenendez approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@amal-k-joy amal-k-joy added this pull request to the merge queue Jul 11, 2024
Merged via the queue into carbon-design-system:main with commit 1b5cdaf Jul 11, 2024
19 checks passed
@amal-k-joy amal-k-joy deleted the conditionBuilder_jul5 branch July 11, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makafsal makafsal makafsal approved these changes

@davidmenendez davidmenendez davidmenendez approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amal-k-joy @davidmenendez @makafsal