fix(CreateFullPage): header height to work properly on older browsers

carbon-design-system · Sep 2, 2024 · 28cc0ca · 28cc0ca
1 parent c7d1ef3
commit 28cc0ca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap b/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap
@@ -2126,10 +2126,9 @@ p.c4p--about-modal__copyright-text:first-child {
   display: grid;
   height: 100%;
   color: var(--cds-text-primary, #161616);
-  grid-template-rows: minmax(auto, 100%);
 }
 .c4p--create-full-page:has(.c4p--create-full-page__header) {
-  grid-template-rows: auto minmax(auto, 100%);
+  grid-template-rows: auto minmax(min-content, 100%);
 }
 
 .c4p--create-full-page .c4p--create-full-page__content .cds--grid {
@@ -3982,6 +3981,10 @@ p.c4p--about-modal__copyright-text:first-child {
   padding: 0;
 }
 
+.c4p--datagrid .cds--noLabel svg.cds--btn__icon {
+  margin-inline-start: 0;
+}
+
 .c4p--datagrid .cds--action-list .cds--btn__icon {
   margin-top: 0;
 }

diff --git a/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss b/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss
@@ -25,10 +25,10 @@ $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step;
   display: grid;
   height: 100%;
   color: $text-primary;
-  grid-template-rows: minmax(auto, 100%);
+  // grid-template-rows: minmax(auto, 100%);
 
   &:has(.#{$block-class}__header) {
-    grid-template-rows: auto minmax(auto, 100%);
+    grid-template-rows: auto minmax(min-content, 100%);
   }
 }