Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y-SR row count announcement in DataTable with expandable rows #18457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −3
Open

fix: a11y-SR row count announcement in DataTable with expandable rows #18457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ddc841
fix: a11y-SR row count announcement in DataTable with expandable rows
2nikhiltom Jan 28, 2025
6a23b0e
Merge branch 'main' into datatable-row-count-a11y
Gururajj77 Jan 29, 2025
ff6b149
Merge branch 'main' into datatable-row-count-a11y
2nikhiltom Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/react/src/components/DataTable/stories/DataTable-ai-label.stories.js
View file
Original file line number Diff line number Diff line change
@@ -386,7 +386,9 @@ export const AILabelWithExpansion = (args) => (
<TableBody>
{rows.map((row, i) => (
<React.Fragment key={row.id}>
<TableExpandRow {...getRowProps({ row })}>
<TableExpandRow
{...getRowProps({ row })}
aria-expanded={row.isExpanded}>
{i === 3 || i === 4 || i === 1 ? (
<TableDecoratorRow decorator={aiLabel} />
) : (
@@ -397,6 +399,7 @@ export const AILabelWithExpansion = (args) => (
))}
</TableExpandRow>
<TableExpandedRow
aria-hidden={!row.isExpanded}
colSpan={headers.length + 2}
className="demo-expanded-td"
{...getExpandedRowProps({ row })}>
@@ -456,7 +459,9 @@ export const ColumnAILabelWithSelectionAndExpansion = (args) => (
{rows.map((row) => {
return (
<React.Fragment key={row.id}>
<TableExpandRow {...getRowProps({ row })}>
<TableExpandRow
{...getRowProps({ row })}
aria-expanded={row.isExpanded}>
<TableSelectRow {...getSelectionProps({ row })} />
{row.cells.map((cell) => {
return (
@@ -467,6 +472,7 @@ export const ColumnAILabelWithSelectionAndExpansion = (args) => (
})}
</TableExpandRow>
<TableExpandedRow
aria-hidden={!row.isExpanded}
colSpan={headers.length + 2}
className="demo-expanded-td"
{...getExpandedRowProps({ row })}>
5 changes: 4 additions & 1 deletion ...act/src/components/DataTable/stories/dynamic-content/DataTable-dynamic-content.stories.js
View file
Original file line number Diff line number Diff line change
@@ -249,13 +249,16 @@ export const Default = (args) => {
<TableBody>
{rows.map((row) => (
<React.Fragment key={row.id}>
<TableExpandRow {...getRowProps({ row })}>
<TableExpandRow
{...getRowProps({ row })}
aria-expanded={row.isExpanded}>
<TableSelectRow {...getSelectionProps({ row })} />
{row.cells.map((cell) => (
<TableCell key={cell.id}>{cell.value}</TableCell>
))}
</TableExpandRow>
<TableExpandedRow
aria-hidden={!row.isExpanded}
colSpan={headers.length + 3}
className="demo-expanded-td"
{...getExpandedRowProps({ row })}>
2 changes: 2 additions & 0 deletions packages/react/src/components/DataTable/stories/expansion/DataTable-expansion.stories.js
View file
Original file line number Diff line number Diff line change
@@ -83,13 +83,15 @@ export const Default = (args) => (
{rows.map((row) => (
<React.Fragment key={row.id}>
<TableExpandRow
aria-expanded={row.isExpanded}
{...getRowProps({ row })}
onClick={action('onClick')}>
{row.cells.map((cell) => (
<TableCell key={cell.id}>{cell.value}</TableCell>
))}
</TableExpandRow>
<TableExpandedRow
aria-hidden={!row.isExpanded}
colSpan={headers.length + 1}
className="demo-expanded-td"
{...getExpandedRowProps({ row })}>