-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: onChange
calls reduced to 1 when interacting with keyboard
#18435
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18435 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 408 408
Lines 14456 14460 +4
Branches 4703 4703
=======================================
+ Hits 12162 12166 +4
- Misses 2128 2129 +1
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected! LGTM 🚀
It just have to remove the test stories before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@Gururajj77 It just have to remove the test stories |
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Closes #18386
Fixed the
onChange
from getting fired twice.Changelog
New
highlightedIndex === -1
to make sure theonChange
fires only if theinputValue
does not match with any of the items.Changed
Testing / Reviewing