-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Breadcrumb): parity issues #18414
base: main
Are you sure you want to change the base?
fix(Breadcrumb): parity issues #18414
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18414 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 408 408
Lines 14449 14449
Branches 4696 4646 -50
=======================================
Hits 12161 12161
Misses 2124 2124
Partials 164 164 ☔ View full report in Codecov by Sentry. |
Closes #17929
Breadcrumb - react and wc parity
Added props such as ariaCurrent, isCurrentPage, noTrailingSlash.
Added OverflowMenu hover feature in breadcrumb. For this I had a discussion with @annawen1 and @kennylam, as suggested by Anna, I added a
breadcrumb
prop inoverflow-menu.ts
for overriding the styles in breadcrumb component.Changelog
Changed
Testing / Reviewing
Tested using storybook , can be checked in storybook controls.