Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Breadcrumb): parity issues #18414

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

anamikaanu96
Copy link
Contributor

@anamikaanu96 anamikaanu96 commented Jan 23, 2025

Closes #17929

Breadcrumb - react and wc parity
Added props such as ariaCurrent, isCurrentPage, noTrailingSlash.
Added OverflowMenu hover feature in breadcrumb. For this I had a discussion with @annawen1 and @kennylam, as suggested by Anna, I added a breadcrumb prop in overflow-menu.ts for overriding the styles in breadcrumb component.

Changelog

Changed

  • packages/web-components/src/components/breadcrumb/breadcrumb-link.ts
  • packages/web-components/src/components/breadcrumb/breadcrumb.scss
  • packages/web-components/src/components/breadcrumb/breadcrumb.stories.ts
  • packages/web-components/src/components/breadcrumb/breadcrumb.ts
  • packages/web-components/src/components/overflow-menu/overflow-menu.scss
  • packages/web-components/src/components/overflow-menu/overflow-menu.ts

Testing / Reviewing

Tested using storybook , can be checked in storybook controls.

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner January 23, 2025 16:27
@anamikaanu96 anamikaanu96 marked this pull request as draft January 23, 2025 16:27
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f352d58
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6799fe493d89dc000844da48
😎 Deploy Preview https://deploy-preview-18414--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f352d58
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6799fe49ac0d040008a8bc60
😎 Deploy Preview https://deploy-preview-18414--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f352d58
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6799fe49836b590008776586
😎 Deploy Preview https://deploy-preview-18414--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (051cedd) to head (f352d58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18414   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14449    14449           
  Branches     4696     4646   -50     
=======================================
  Hits        12161    12161           
  Misses       2124     2124           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anamikaanu96 anamikaanu96 marked this pull request as ready for review January 29, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Breadcrumb
3 participants