Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): resolve parity issue two handle feature #18394

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Jan 22, 2025

Closes #17580

Two handle slider feature added to Web Components

Changelog

New

  • Two handle slider feature added

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit db52572
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67909126f4b77e00084e5327
😎 Deploy Preview https://deploy-preview-18394--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit db52572
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6790912636770800085a4ed6
😎 Deploy Preview https://deploy-preview-18394--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db52572
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/679091263b4684000861a126
😎 Deploy Preview https://deploy-preview-18394--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6792140849f1d600080ec8c6
😎 Deploy Preview https://deploy-preview-18394--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67921408a9ac3c0008016337
😎 Deploy Preview https://deploy-preview-18394--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d7dfe4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67921408e3b6de0008a36555
😎 Deploy Preview https://deploy-preview-18394--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (02d6f94) to head (6d7dfe4).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18394   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4690           
=======================================
  Hits        12150    12150           
  Misses       2120     2120           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sangeethababu9223 sangeethababu9223 deleted the fix/slider-parity-check-react-wc branch January 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Support two knobs
1 participant