WIP | fix: stopped combobox's onChange
throwing undefined when selected item is clicked again and fixed keyboard interaction
#18387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18286
Closes #18386
18226 issue: stops the onChange handler from firing with undefined when the same item is clicked. Now it does not fire
onChange
handler when the selected item is clicked again.Second: The keyboard interaction would fire 2
onChange
handlers, one with previously selected value and one with the new selected value.Changelog
Changed
onStateChange
to include a check for being undefined:newSelectedItem !== undefined
Removed
if (allowCustomValue && isOpen && inputValue) {onChange({ selectedItem, inputValue });}Removed this condition as this was firing the onChange with previous selected value when the combobox is interacted with keyboard
Testing / Reviewing
Parent onChange called with: 2