Add support for HTTPS upstream, make sure to pass the upstream Host header #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| location / { | ||
| proxy_pass $upstream; | ||
| proxy_set_header Host $http_host; |
There was a problem hiding this comment.
The point of this line was to ensure we pass the same HOST to the upstream. With this change, we're always passing the HOST of the upstream itself which breaks the existing applications.
I think we may be able to do this, but we need to limit this only to HTTPS upstream. If the upstream is a plain HTTP, we need to ensure we're not changing this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Hostheader - so the upstream server doesn't need to support the additional reverse proxy hostname