#1168@patch: Normalize whitespace in processing of DOMTokenList. #1169
Conversation
| private _getTokenList(): string[] { | ||
| let attr = this._ownerElement.getAttribute(this._attributeName) ?? ''; | ||
| attr = attr.replace(/^[\t\n\f\r ]+|[\t\n\f\r ]+$/g, ''); | ||
| attr = attr.replace(/[\t\n\f\r ]+/g, ' '); |
There was a problem hiding this comment.
Hard to demonstrate as I’m typing on mobile, but String.prototype.split() accepts RegExp so this replace() and the next split() could both be reduced to one step.
There was a problem hiding this comment.
Thank you for the review. I have merged the two lines.
I learned a lot this time that String.prototype.split() accepts RegExp. Thank you again.
* String.prototype.split() accepts RegExp. * RegExp's g flag is ignored in split() so that g flag was removed.
takenspc
force-pushed
the
task/1168-normalize-whitespace
branch
from
eadf1bf to
1f5a301
Compare
…o task/1168-normalize-whitespace
There was a problem hiding this comment.
Thank you for your contribution @takenspc! 🌟
Sorry for taking such a long time before reviewing this.
I have made some improvements to the logic in DOMTokenList.#getTokenList() to improve its performance. I also merged the code and changed it to follow the new coding guidelines of using Symbol() or # for internal properties instead of "_" as prefix.
… after in DOMTokenList.
Normalize whitespace before splitting text into tokens.
Fixes #1168.