Add json support with binary fields via base64 encoding #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikandreas
force-pushed
the
master
branch
from
f46d6b6
to
da4018f
Compare
haata
reviewed
Jan 23, 2024
|
|
||
| @pytest.fixture | ||
| def blob_schema(): | ||
| return capnp.load(os.path.join(this_dir, "blob_test.capnp")) |
There was a problem hiding this comment.
Did you forget to add blob_test.capnp to the commit?
There was a problem hiding this comment.
thanks, I've added it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use-case requires capnp messages to (also) be serialized to json and deserialized from json. This PR adds support for this by converting binary data to a base64 encoded string, which is compatible with json.
The implementation is non-breaking, the previous behavior stays the same, but can be controlled via a
msg.to_dict(encode_binary_as_base64=True).I realize this might be a rare use-case but doesn't hurt to have it as a feature and at least in my case it's useful to have json as a fallback solution in the communication stack for debugging purposes.