Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests and test network #596

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Semisol
Copy link
Contributor

@Semisol Semisol commented Jan 5, 2025

This PR fixes some tests that failed due to the schema generator and the changed Network interface. This PR makes 2 changes to the (unused) testnetwork functionality:

  • The opts field is now fixed for each vat in the test network.
    • This should be suitable for testing purposes, and it is expected that most applications are not changing their options per client.
    • There was also no way with the previous way to choose the options knowing the remote peer ID, meaning such a use case could not be simulated with the test network anyway.
  • The incomplete 3PH functionality is removed.
    • This should be re-added to match the new interface for tests in the same PR as the first implementation of 3PH.

Copy link
Collaborator

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@lthibault lthibault merged commit 567b3ac into capnproto:main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants