WIP: Handle incoming resolve messages, take 2 #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still TODO: - We need to handle disembargos with target = (importedCap = ...). - Testing.
The := below is sufficient, since this isn't actually used before that.
Also, along the way, use the snapshot from resultsCapTable instead of calling .Snapshot() on the client.
Needs testing.
The test is currently failing; we're getting back an abort message complaining that the export entry is not a promise -- need to investigate. Aside from that failure, this caught a bug: we need to check if ClientState.Metadata is nil, which is possible if the client itself is null, and seems to happen to the promise after it is resolved. TODO: we should de-dup the logic between releaseExport and releaseExports. This is not entirely trivial though, because the latter is executed after we've wiped the exports table.
...also failing (hanging) for now.
|
(Note: there are some bits from the other PR that I haven't pulled in yet, which may address some of the test failures) |
...which we were forgetting to set. We can query snapshot for this anyway, so just get rid of it -- single source of truth and all.
When looking at the target of the promise, we want to look at its *resolution.*
Otherwise we get a runtime error sometimes.
...the latter often just results in me staring at cascading errors, which is unhelpful.
Push the logic for flushing the answerqueue into the Promise type itself. This is much cleaner, and avoids some racy logic that I'm not sure was correct.
lthibault
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #480, whose conflicts were formidable enough that I had to cherry-pick and transcribe somewhat manually. It is conceptually the same change.
Some of the tests are failing, so this is a draft for now.