Use ClientSnapshot in the export table, rather than Client #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of a Client. This is a step towards addressing the tribble 4-way race condition. Currently there are some test failures.
The call to waitRef.Release() in export.go was resolving the receiver too soon, resulting in a leak.
|
We will probably also need to do something with capnp.Promise/answers, but this is at least half of solving the 4-way race. |
lthibault
approved these changes
May 29, 2023
|
I merged master back in, which should fix the CI failure. Test suite passes 1000 times in a row locally. |
lthibault
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also tweaks the leak reporting to also check snapshots.