-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clippy linting CI target #458
Conversation
cb3c8c4
to
dced107
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 51.49% 51.55% +0.05%
==========================================
Files 69 69
Lines 33732 33733 +1
==========================================
+ Hits 17371 17390 +19
+ Misses 16361 16343 -18 ☔ View full report in Codecov by Sentry. |
345f095
to
1f97eda
Compare
@dwrensha this is complete and ready for review. Note that to get the linting to pass i've had to temporarily suppress a type complexity lint. |
1f97eda
to
8fd0c8c
Compare
@@ -21,3 +21,9 @@ features = ["std"] | |||
[dependencies] | |||
capnp-futures = { version = "0.18.0", path = "../capnp-futures" } | |||
capnp = {version = "0.18.0", path = "../capnp"} | |||
|
|||
#[lints] | |||
#workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above. this should be uncommented as soon as the type complexity lint is addressed.
Would you prefer i remove the commented sections?
adds a clippy linting CI target.
Couple of questions on this-