Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clippy linting CI target #458

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

danieleades
Copy link
Contributor

adds a clippy linting CI target.

Couple of questions on this-

  • what is the best possible combination of features to use for linting?
  • would you prefer to have the compiler version used for clippy linting be pinned? (that prevents build failures on PRs due to new lints, but means the version must be manually updated at intervals)

@danieleades danieleades mentioned this pull request Nov 29, 2023
@danieleades danieleades force-pushed the ci-clippy branch 3 times, most recently from cb3c8c4 to dced107 Compare November 30, 2023 06:54
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (cc223f5) 51.49% compared to head (ac9e802) 51.55%.

Files Patch % Lines
capnp-rpc/src/rpc.rs 50.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   51.49%   51.55%   +0.05%     
==========================================
  Files          69       69              
  Lines       33732    33733       +1     
==========================================
+ Hits        17371    17390      +19     
+ Misses      16361    16343      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danieleades
Copy link
Contributor Author

@dwrensha this is complete and ready for review.

Note that to get the linting to pass i've had to temporarily suppress a type complexity lint.
I'm not in a position to create the type aliases to make this lint happy, as the types are impenetrable to me (which illustrates the value of the lint!)
I leave that as an exercise ;)

@danieleades danieleades marked this pull request as ready for review November 30, 2023 07:50
capnp/Cargo.toml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@@ -21,3 +21,9 @@ features = ["std"]
[dependencies]
capnp-futures = { version = "0.18.0", path = "../capnp-futures" }
capnp = {version = "0.18.0", path = "../capnp"}

#[lints]
#workspace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above. this should be uncommented as soon as the type complexity lint is addressed.

Would you prefer i remove the commented sections?

@danieleades danieleades marked this pull request as draft December 3, 2023 08:36
@danieleades danieleades marked this pull request as ready for review December 3, 2023 08:44
@danieleades danieleades requested a review from dwrensha December 3, 2023 08:44
@dwrensha dwrensha merged commit eaad5e5 into capnproto:master Dec 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants