Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove prefect dependency #485

Merged
merged 2 commits into from
Sep 23, 2024
Merged

remove prefect dependency #485

merged 2 commits into from
Sep 23, 2024

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Sep 20, 2024 •
edited
Loading

What

  • next step in deprecating workflow module - followup to deprecate prefect tasks #483
  • removes the hard dependency on prefect
    • workflow module is still usable if prefect is installed explicitly

How to Test

  • python -m pytest

To Do

  • remember to remove prefect dependency in the feedstock when the PR is auto-opened

@ryanSoley ryanSoley requested review from a team as code owners September 20, 2024 22:02
@ryanSoley ryanSoley self-assigned this Sep 20, 2024
thebrianbn
thebrianbn approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@thebrianbn thebrianbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shania-m
shania-m approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@shania-m shania-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanSoley ryanSoley merged commit cfc90ab into main Sep 23, 2024
7 checks passed
@ryanSoley ryanSoley deleted the remove-prefect-dependency branch September 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianbn thebrianbn thebrianbn approved these changes

@shania-m shania-m shania-m approved these changes

Assignees

@ryanSoley ryanSoley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanSoley @thebrianbn @shania-m