-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix(Makefile): Add check to pip, pipenv, and postgresql installations #43
Merged
ksneab7
merged 7 commits into
capitalone:main
from
elitechance:patch/fix-complete-install
Sep 19, 2023
Merged
🐛 fix(Makefile): Add check to pip, pipenv, and postgresql installations #43
ksneab7
merged 7 commits into
capitalone:main
from
elitechance:patch/fix-complete-install
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elitechance
requested review from
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
September 18, 2023 18:17
Ethan Gomez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
elitechance
changed the title
patch
🐛 fix(Makefile): Add check to pip, pipenv, and postgresql installations
Sep 18, 2023
ksneab7
reviewed
Sep 18, 2023
brew install postgresql | ||
else | ||
echo "Error! postgresql not supported by $(shell uname -s)" | ||
exit 125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the checks for OS!
ksneab7
approved these changes
Sep 18, 2023
micdavis
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will perform a check to verify whether the
pip
,pipenv
andPostSQL
are already installed. If they are not detected, it will proceed to install these applications.