Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(Makefile): Add check to pip, pipenv, and postgresql installations #43

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

elitechance
Copy link
Contributor

@elitechance elitechance commented Sep 18, 2023

This patch will perform a check to verify whether the pip, pipenv and PostSQL are already installed. If they are not detected, it will proceed to install these applications.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ethan Gomez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@elitechance elitechance changed the title patch 🐛 fix(Makefile): Add check to pip, pipenv, and postgresql installations Sep 18, 2023
brew install postgresql
else
echo "Error! postgresql not supported by $(shell uname -s)"
exit 125
Copy link
Contributor

@ksneab7 ksneab7 Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the checks for OS!

@ksneab7 ksneab7 merged commit c6cdd6e into capitalone:main Sep 19, 2023
8 checks passed
@taylorfturner taylorfturner added the documentation Improvements or additions to documentation label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants