Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create javascript_client folder #35

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore: create javascript_client folder #35

merged 1 commit into from
Jul 20, 2023

Conversation

openrijal
Copy link
Contributor

  • create javascript_client folder
  • move README.md to parent
  • create relevant README.md for each client

@taylorfturner taylorfturner enabled auto-merge (squash) July 20, 2023 16:43
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

taylorfturner
taylorfturner suggested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • your commit is not signed with your username
  • and you'll need to sign the CLA

@taylorfturner taylorfturner added the documentation Improvements or additions to documentation label Jul 20, 2023
auto-merge was automatically disabled July 20, 2023 17:03

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner enabled auto-merge (squash) July 20, 2023 17:03
taylorfturner
taylorfturner approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorfturner taylorfturner merged commit eb4c6b9 into capitalone:main Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner approved these changes

@ksneab7 ksneab7 ksneab7 approved these changes

@JGSweets JGSweets Awaiting requested review from JGSweets

@micdavis micdavis Awaiting requested review from micdavis

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees

@openrijal openrijal

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openrijal @CLAassistant @taylorfturner @ksneab7