Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.9 support #363

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Remove Python 3.9 support #363

merged 1 commit into from
Jan 6, 2025

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Jan 3, 2025

@gliptak
Remove Python 3.9 support
37e58e0 
Signed-off-by: Gábor Lipták <[email protected]>
@gliptak
Copy link
Contributor Author

gliptak commented Jan 6, 2025

there were no changes causing the lint/format failure

fdosani
fdosani approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@fdosani fdosani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the linting issue might be the change from 3.9 to 3.10 and using X | Y vs Union. Will need to tinker with it a bit more.

@fdosani fdosani merged commit e62247a into capitalone:develop Jan 6, 2025
38 of 39 checks passed
@gliptak gliptak mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdosani fdosani fdosani approved these changes

@ak-gupta ak-gupta Awaiting requested review from ak-gupta ak-gupta is a code owner

@jdawang jdawang Awaiting requested review from jdawang jdawang is a code owner

@gladysteh99 gladysteh99 Awaiting requested review from gladysteh99 gladysteh99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gliptak @fdosani